Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing advanced indexing operation for empty arrays #504

Merged
merged 16 commits into from
Aug 22, 2022
Merged

fixing advanced indexing operation for empty arrays #504

merged 16 commits into from
Aug 22, 2022

Conversation

ipdemes
Copy link
Contributor

@ipdemes ipdemes commented Aug 4, 2022

This PR fixes test cases when input/index and/or values are empty arrays
It depends on nv-legate/legate#319 to me merged first

@ipdemes
Copy link
Contributor Author

ipdemes commented Aug 11, 2022

This PR also fixes reshape for empty arrays with ndim >1 (arrays with shapes (1,0), (1,0,0) e.t.c)

manopapad
manopapad reviewed Aug 12, 2022
View reviewed changes
cunumeric/deferred.py Outdated Show resolved Hide resolved
manopapad
manopapad reviewed Aug 12, 2022
View reviewed changes
cunumeric/deferred.py Outdated Show resolved Hide resolved
ipdemes
ipdemes commented Aug 18, 2022
View reviewed changes
cunumeric/deferred.py Outdated Show resolved Hide resolved
ipdemes
ipdemes commented Aug 18, 2022
View reviewed changes
cunumeric/deferred.py Outdated Show resolved Hide resolved
manopapad
manopapad reviewed Aug 19, 2022
View reviewed changes
cunumeric/deferred.py Outdated Show resolved Hide resolved
manopapad
manopapad reviewed Aug 19, 2022
View reviewed changes
cunumeric/array.py Outdated Show resolved Hide resolved
manopapad
manopapad reviewed Aug 19, 2022
View reviewed changes
cunumeric/deferred.py Outdated Show resolved Hide resolved
@mfoerste4 mfoerste4 mentioned this pull request Aug 19, 2022
Merged
@ipdemes ipdemes requested a review from manopapad August 19, 2022 19:46
manopapad
manopapad approved these changes Aug 19, 2022
View reviewed changes
Copy link
Contributor

@manopapad manopapad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job fixing this very stupid corner case

@ipdemes
Copy link
Contributor Author

ipdemes commented Aug 19, 2022

Thank you, Manolis! Will merge it after CI passes

@ipdemes ipdemes merged commit ede9793 into nv-legate:branch-22.10 Aug 22, 2022
jjwilke pushed a commit to jjwilke/cunumeric that referenced this pull request Sep 2, 2022
@ipdemes @jjwilke
fixing advanced indexing operation for empty arrays (nv-legate#504)
74ff168 
fixing advanced indexing operation for empty arrays
@ipdemes ipdemes deleted the fix_advanced_indexing branch January 12, 2023 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryevdv bryevdv bryevdv left review comments

@manopapad manopapad manopapad approved these changes

@magnatelee magnatelee Awaiting requested review from magnatelee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ipdemes @manopapad @bryevdv